Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Accordion] Replace hardcoded classes with constants in demos #44453

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Nov 18, 2024

While addressing an issue, I noticed that some Accordion demos use hardcoded class names for styling. This is a bad practice for multiple reasons, and we should use constants for class names in our demos instead.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: accordion This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Nov 18, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][Accordion] Replace hardcoded classes with constants [docs][Accordion] Replace hardcoded classes with constants in demos Nov 18, 2024
@mui-bot
Copy link

mui-bot commented Nov 18, 2024

Netlify deploy preview

https://deploy-preview-44453--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ac04e67

Copy link
Contributor

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ZeeshanTamboli ZeeshanTamboli merged commit 5849e4d into mui:master Nov 18, 2024
22 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-hardcoded-accordion-classes branch November 18, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants